Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid path for cleanup-test-schemas #163

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Conversation

atzoum
Copy link
Collaborator

@atzoum atzoum commented Aug 26, 2024

Description

Moving cleanup command to its own folder

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@atzoum atzoum force-pushed the chore.cleanuptestschemas branch from 8e1590d to 279bc57 Compare August 26, 2024 10:28
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 85.52%. Comparing base (668e73f) to head (279bc57).
Report is 1 commits behind head on main.

Files Patch % Lines
sqlconnect/cmd/cleanup/cleanup.go 0.00% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
- Coverage   85.70%   85.52%   -0.19%     
==========================================
  Files          78       78              
  Lines        3323     3330       +7     
==========================================
  Hits         2848     2848              
- Misses        321      328       +7     
  Partials      154      154              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atzoum atzoum merged commit 0f5a676 into main Aug 26, 2024
22 checks passed
@atzoum atzoum deleted the chore.cleanuptestschemas branch August 26, 2024 10:34
atzoum pushed a commit that referenced this pull request Aug 26, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.9.0](v1.8.0...v1.9.0)
(2024-08-26)


### Features

* **trino:** bump github.com/trinodb/trino-go-client from 0.315.0 to
0.316.0 ([#167](#167))
([6ec9892](6ec9892))


### Bug Fixes

* invalid path for cleanup-test-schemas
([#163](#163))
([0f5a676](0f5a676))


### Miscellaneous

* cleanup test schemas periodically
([#161](#161))
([668e73f](668e73f))
* **deps:** bump github.com/aws/aws-sdk-go-v2/service/sts from 1.30.3 to
1.30.5 ([#166](#166))
([154aae8](154aae8))
* **deps:** bump github.com/samber/lo from 1.46.0 to 1.47.0
([#165](#165))
([2f1a72f](2f1a72f))
* **deps:** bump google.golang.org/api from 0.189.0 to 0.194.0
([#164](#164))
([55aaa55](55aaa55))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant